Adding a --account-hw to ethers-cli & ethers-ens.

ethers-io / ethers-cli

Deprecated; please see the `@ethersproject/cli` package instead

https://github.com/ethers-io/ethers.js/tree/ethers-v5-beta/packages/cli

17 stars 13 forks source link

Adding a --account-hw to ethers-cli & ethers-ens. #5

Open Amxx opened 4 years ago

Amxx commented 4 years ago

The documentation of ethers-cli & ethers-ens, describes numerous ways to connect to an account. however, their doesn't appear to be a option of hardware wallets (ledger in my case). I believe using @ethersproject/hardware-wallets this is something that could be added pretty easily. I would definitelly have usecases for it!

ricmoo commented 4 years ago

This will be going in soon. It was removed because the LedgerSigner was not ported to v5 yet, but now that it is, it will be added back to the CLI.

Amxx commented 4 years ago

Sorry to bother you, but is that, somehow, in the backlog?

ricmoo commented 4 years ago

Yes. I've changed this issue from discussion to enhancement to make that more clear. :)