ethers-io / ethers.io

Frontend website HTML, JavaScript and CSS for ethers.io.
https://ethers.io
MIT License
41 stars 18 forks source link

Setting gas limit & detecting "Out of Gas" for Solidity Contract deployment #12

Closed GFJHogue closed 6 years ago

GFJHogue commented 6 years ago

Hi Richard!

  1. When deploying a larger contract, the default gas limit sometimes doesn't make the cut. Allowing users to set it would be nice.

  2. If a deploy transaction runs out of gas during contract creation (example), it still shows as successfully deployed on ethers.io.

ricmoo commented 6 years ago

The old Solidity compiler has been deprecated and now this just uses the normal Remix IDE (using the Web3 Bridge). The new Ethers Container is much smarter at choosing a gas limit as well, so this should be fixed.

Thanks!