fixed provider-jsonrpc.ts strict compile fixes and error handling

ethers-io / ethers.js

Complete Ethereum library and wallet implementation in JavaScript.

https://ethers.org/

MIT License

7.98k stars 1.86k forks source link

fixed provider-jsonrpc.ts strict compile fixes and error handling #4837

Closed apetersson closed 1 month ago

apetersson commented 2 months ago

The original condition used "NETWORK_ERROR" || isError(error, "UNSUPPORTED_OPERATION") which is always truthy due to the way the logical OR operator (||) is evaluated. This caused the if statement to not function as intended, potentially resulting in unexpected rejections during transaction handling.

ricmoo commented 1 month ago

Sorry this slipped through the cracks. I'm looking into it now.

ricmoo commented 1 month ago

This has been fixed in v6.13.4.

Thanks! And sorry for the delay.