ethersheet-collective / EtherSheet

Online spreadsheet collaboration in real time using node.js. Similar to etherpad-lite but its a spreadsheet!
https://ethersheet.org
BSD 2-Clause "Simplified" License
198 stars 24 forks source link

no method 'xss' - Install worked, kinda runs. #3

Closed fsargent closed 10 years ago

fsargent commented 10 years ago

TypeError: Object [object Object] has no method 'xss' at Function.Command.sanitize (/usr/local/lib/node_modules/es_command/es_command.js:22:32) at Object.Command.initWithString (/usr/local/lib/node_modules/es_command/es_command.js:35:35) at Object.module.exports (/usr/local/lib/node_modules/es_command/es_command.js:14:10) at null.transaction_handler (/data/EtherSheet/lib/server.js:101:13) at SockJSConnection. (/data/EtherSheet/transactor/transactor.js:30:11) at SockJSConnection.EventEmitter.emit (events.js:95:17) at Session.didMessage (/data/EtherSheet/node_modules/sockjs/lib/transport.js:220:25) at App.exports.app.xhr_send (/data/EtherSheet/node_modules/sockjs/lib/trans-xhr.js:81:15) at execute_request (/data/EtherSheet/node_modules/sockjs/lib/webjs.js:21:38) at req.next_filter (/data/EtherSheet/node_modules/sockjs/lib/webjs.js:95:18)

0xnbk commented 10 years ago

+1 I am also having the same issue. Every time while accessing a spread sheet, this error throws up.

cooperq commented 10 years ago

Hmm it seems that the sanitize object doesn't know about the xss() method (used to strip common xss attacks). Can you send me the output of npm list as well as your node.js version? And can you give me the steps to reproduce this error?

fsargent commented 10 years ago

https://gist.github.com/fsargent/aa50db5d956f1b06c082

cooperq commented 10 years ago

ah it seems that in newer versions of the validator package, the xss filter has been removed in favor of the more secure 'escape' filter. I will fix this issue today.

cooperq commented 10 years ago

Fixed in commit latest for es_command and the latest commit for es_client. Please pull updates of both of those repositories to get this fix.

fsargent commented 10 years ago

Gotta fix that trailing comma in es_command :)