search

ethersphere / bee-backlog

zenhub epics repo
0 stars 0 forks source link

Retrieval protocol is unreadable #36

Closed acud closed 1 year ago

acud commented 2 years ago

It has too much nesting and its not even remotely possible to understand what's going on without wasting hours at a time.

Another big problem we saw is that the logging is confusing. e.g. we always log when a request is issued, but not always when we have an error. This led is to believe there's a problem with the protocol logic and we spend an hour just to see that the result is not always logged, however, looking at the logs we could see duplicate lines of requests, that suggested that there's a problem.

AuHau commented 2 years ago

I would maybe suggest having a look on the Bee node bootstrapping as well ;-) Having 900 lines function does not seem to me like the best

acud commented 2 years ago

PRs for improving the bootstrapper are welcome @AuHau. Also, I don't think the two are comparable in complexity. I'm sure you can understand how the bootstrapper works.

agazso commented 2 years ago

The idea here is that the research team could provide a written documentation about the components and their interaction and from that a proposal can be created.

istae commented 1 year ago

Fixed by https://github.com/ethersphere/bee/pull/3428