search

ethersphere / bee-clef

bee-clef is official ethereum clef binary wrapped and preconfigured for bee as a service
GNU General Public License v3.0
79 stars 50 forks source link

add --lightkdf arg for clef's newaccount command #19

Closed attila-lendvai closed 3 years ago

attila-lendvai commented 3 years ago

clef's memory usage can be enormous with the normal KDF parameters, sometimes growing beyond 10GB! with this change, it remains in the ballpark of 70kB.

https://github.com/ethereum/go-ethereum/issues/22361

attila-lendvai commented 3 years ago

NOTE: it only affects the creation of new keys. old keys will behave the same.

i have no idea about how hard it is to migrate old keys, or whether we should care about them. anyone wiser than me please do speak up!

vandot commented 3 years ago

@attila-lendvai thanks, but probably we should also specify it when starting the service like here https://github.com/ethersphere/bee-clef/pull/21

attila-lendvai commented 3 years ago

that won't hurt, but AFAIU it only matters when new keys are generated.