search

ethersphere / bee-clef

bee-clef is official ethereum clef binary wrapped and preconfigured for bee as a service
GNU General Public License v3.0
79 stars 50 forks source link

added packaging/nix/maybe-initialize-clef #7

Closed attila-lendvai closed 3 years ago

attila-lendvai commented 3 years ago

it's basically the same what is in the postinst script, with the following changes:

the current version of the nix package calls this script. the Nix PR is here: https://github.com/NixOS/nixpkgs/pull/109393 (still a draft at the time of writing)

attila-lendvai commented 3 years ago

@vandot as discussed, i have moved the file into the packaging/nix directory. as for me, it's ready for merging.

vandot commented 3 years ago

@attila-lendvai can you please rename maybe-initialize-clef to something more meaningful?

attila-lendvai commented 3 years ago

@vandot this is the most meaningful name that i could think of, and it still is.

what else do you suggest? i think ensure-clef-account is another reasonable one.

vandot commented 3 years ago

@attila-lendvai maybe clef-init?

attila-lendvai commented 3 years ago

@attila-lendvai maybe clef-init?

that name is misleading, because it only inits clef if it hasn't been initialized yet.

"ensure" or "maybe" in the name communicates that it doesn't necessarily do anything.

on NixOS it's called from the preStart hook of the service every time the service is started.

attila-lendvai commented 3 years ago

@vandot i was thinking a bit more, and i think it makes more sense to put this file into the nix package description, because then the nix package can be worked on without having to open PR's to this repo and coordinate on their merging.

i'm closing this PR, sorry for the noise! and thanks for the help!