ethersphere / bee

Bee is a Swarm client implemented in Go. It’s the basic building block for the Swarm network: a private; decentralized; and self-sustaining network for permissionless publishing and access to your (application) data.
https://www.ethswarm.org
BSD 3-Clause "New" or "Revised" License
1.44k stars 338 forks source link

fix: rename swarm key #4647

Open ersonp opened 2 months ago

ersonp commented 2 months ago

Checklist

Description

In a new node wallet.key will be created instead of swarm.key. In an old node the swarm.key will be renamed to wallet.key on start. Due to this, downgrading the node won't be possible because of the name change.

Open API Spec Version Changes (if applicable)

Motivation and Context (Optional)

Related Issue (Optional)

fixes #4023

Screenshots (if appropriate):

ldeffenb commented 2 months ago

Why? Since the swarm.key is also used to generate the swarm overlay? It's not just a "wallet" key IMHO.

ersonp commented 2 months ago

Frankly, I am not qualified/experienced enough in bee to give a proper reason for the change. I am just looking around to contribute to this project and I found https://github.com/ethersphere/bee/issues/4023 in the good first issues.