smoke helm chart: use correct influxdb endpoint

ethersphere / helm-charts

Helm charts to deploy Swarm and Geth

6 stars 4 forks source link

smoke helm chart: use correct influxdb endpoint #22

Closed nonsense closed 5 years ago

skylenet commented 5 years ago

Wouldn't it make more sense to have the whole endpoint configurable ?

e.g.

template:

- --metrics.influxdb.endpoint={{ .Values.smoke.config.influxdbendpoint }}

vars:

smoke:
  config:
    influxdbendpoint: http://influxdb:8086

That way you could target any influxdb without having to rely on these conventions. It could be one that way deployed independently of swarm.

nonsense commented 5 years ago

It can't be the full endpoint, because it contains the namespace which changes between users. Therefore we won't have a good default value - a user would have to always configure this correctly for it to work.

Also this shouldn't be any influxdb - we want this to be the influxdb deployed with Swarm. I don't see anyone specifically deploying influxdb for the smoke tests.

nonsense commented 5 years ago

@skylenet I am not sure why I was under the impression that namespace is required. Just tested DNS within a given namespace and it is actually not required. So I will configure this as you suggest.