fix: signMessage - Githubissues

etherspot / etherspot-prime-sdk

Etherspot Prime - Account Abstraction SDK

https://etherspot.fyi

MIT License

120 stars 22 forks source link

fix: signMessage #118

Closed chichke closed 3 months ago

chichke commented 3 months ago

Description

Sign message rpc parameters should be in the correct order according to the rpc documentation msg params should always be first

Types of changes

What types of changes does your code introduce?

[ X ] Bugfix (non-breaking change which fixes an issue)

Further comments (optional)

web3auth integration doesn't work anymore without this fix

telegram-cloud-photo-size-4-5916026604100895045-y

ch4r10t33r commented 3 months ago

Thanks for submitting this PR @chichke , This is being reviewed right now. We'll merge it soon.

vignesha22 commented 3 months ago

@chichke Thanks for contributing. I will close this PR since we have checks to change the changelog file too and thats what was missing but as you know already I have another PR waiting to merge hence added those fixes on the signTypedData PR.