etherspot / skandha

A modular typescript implementation of ERC4337 (Account Abstraction) bundler client.
https://etherspot.io
MIT License
562 stars 56 forks source link

feat: flashbots #130

Closed 0xSulpiride closed 10 months ago

0xSulpiride commented 10 months ago

Description

Tested on Sepolia https://sepolia.etherscan.io/tx/0xcf1589b7e80e0d6f22b13e8aa6425c61c90bf127ec34b5bf02fa85766809627f There's some weird issue on Sepolia. https://relay-sepolia.flashbots.net is always returning "internal server error" even if a bundle is successfully submitted (I've reported it to devs on Discord)

Tested on Goerli: https://goerli.etherscan.io/tx/0xab98000a3f9bade11eeb4fffb4c05ba8784da9c39b3136d97319943e4dc18669 https://goerli.etherscan.io/tx/0xf89d34b8147798856dae5e449f5c517d41fde642df975784c60a00df5d995f4c https://goerli.etherscan.io/tx/0xbb95249afa472327bcdbdfe297c8a669cf55e317fb203c84b0eee7166c332c15

Types of changes

What types of changes does your code introduce? Put an x in the boxes that apply

Further comments (optional)

-

0xSulpiride commented 10 months ago

I've addressed issue #124 in this PR, but not other 2. And I've refactored BundlingService with the issue #125 in mind, so it should be easier to implement. @ch4r10t33r

0xSulpiride commented 10 months ago

@ch4r10t33r Looked into it. It's not related to Flashbots and this is the same issue that we're having on Polygon (ticket PRO-2045) We're losing money when a bundle's gas price is equal to a userop's gas price. I will address it in a separate PR since it's not related to Flashbots and we have a separate ticket for this issue.