delete hardcoded mempools & configurable mempool id - Githubissues

etherspot / skandha

A modular typescript implementation of ERC4337 (Account Abstraction) bundler client.

https://etherspot.io

MIT License

560 stars 50 forks source link

delete hardcoded mempools & configurable mempool id #148

Closed 0xSulpiride closed 6 months ago

0xSulpiride commented 7 months ago

Description

deleted all hardcoded mempool ids
mempool id can be set in config.json using these 2 params: canonicalMempoolId and canonicalMempoolEntryPoint

Types of changes

What types of changes does your code introduce? Put an x in the boxes that apply

[ ] Bugfix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] Documentation Update
[ ] Code style update (formatting, renaming)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] Other (please describe):

Further comments (optional)

-

0xSulpiride commented 6 months ago

@ch4r10t33r I'm not sure if this is future-proof, because we would have to change or delete fallback values in case of a change to mempool ids so that adds some maintenance burden on us