fix: invalid bignumber value - eth_estimateUserOperationGas

saqlain1020 commented 3 months ago

Description

Added validations for CG, VG, PVG, paymasterAndData, maxFeePerGas & maxPriorityFeePerGas using class-validators.
Resolves #167

Types of changes

What types of changes does your code introduce? Put an x in the boxes that apply

[x] Bugfix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] Documentation Update
[ ] Code style update (formatting, renaming)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] Other (please describe):

Further comments (optional)

This update will throw Invalid json error, when not supplied with correct params in userop while estimating gas. Before this change bundler was returning Bignumber undefined error when CG, VG , PVG etc was not supplied with the userOp, which made it harder to debug.

0xSulpiride commented 2 months ago

Thanks for reporting the issue! We should keep these fields optional as per the EIP. I investigated the issue and fixed it in this PR - https://github.com/etherspot/skandha/pull/170

@saqlain1020

saqlain1020 commented 2 months ago

@0xSulpiride Understood 👍

etherspot / skandha