ethiotelecom-et / Telebirr

Telebirr integration
https://ethiotelecom-et.github.io/Telebirr/
MIT License
1 stars 0 forks source link

[Support non-ubuntu linux distributions by specify location of versions-manifest.json ](https://github.com/actions/setup-python/issues/716#issue-1848676120) #9

Open Create-action opened 8 months ago

Create-action commented 8 months ago

Description: I'm using GHES with runners under CentOS / Rocky Linux. But setup-python is supported on recent Ubuntu versions only, and it fails on other linux distributions, yet. So, I propose to support other linux distributions by simple changes.

Justification:

  • Recent actions/tool-cache library supports to determine platform version for non-ubuntu linux distros ( Get linux version from os-release file if available toolkit#594 )
  • setup-python actions has hard coded location of versions-manifest.json. If location of versions-manifest.json can be provided users, actions can be used for various linux platform. I propose 3 inputs options for this.

    • versions-manifest-repo-owner : Github owner of versions-manifest.json
    • versions-manifest-repo-name : Github repository of versions-manifest.json
    • versions-manifest-repo-branch : Github branch of versions-manifest.json If these values are not set, default value should be same with current behavior.

Are you willing to submit a PR?

I'll try it :D

create-issue-branch[bot] commented 8 months ago

Could not create branch issue-9-_Support_non-ubuntu_linux_distributions_by_specify_location_of_versions-manifest_json_https_//github_com/actions/setup-python/issues/716#issue-1848676120 due to: refs/heads/issue-9-_Support_non-ubuntu_linux_distributions_by_specify_location_of_versions-manifest_jsonhttps//github_com/actions/setup-python/issues/716#issue-1848676120 is not a valid ref name.