Since eslint is used in the scripts at package.json#7, it also should be added as deps. Then users don't need to install it as a global deps because npm run add node_modules/.bin to PATH automatically.
After that, the following logs are displayed when I ran npm test:
click here
```console
$ npm test
> ethjs-ens@2.0.1 test /Users/watilde/Development/ethjs-ens
> npm run lint && istanbul cover test && npm run coveralls
> ethjs-ens@2.0.1 lint /Users/watilde/Development/ethjs-ens
/Users/watilde/Development/ethjs-ens/index.js
18:11 warning Block must not be padded by blank lines padded-blocks
52:1 error Expected indentation of 6 spaces but found 4 indent
53:1 error Expected indentation of 8 spaces but found 6 indent
54:1 error Expected indentation of 10 spaces but found 8 indent
55:1 error Expected indentation of 8 spaces but found 6 indent
56:1 error Expected indentation of 8 spaces but found 6 indent
57:1 error Expected indentation of 6 spaces but found 4 indent
70:1 error Expected indentation of 6 spaces but found 4 indent
78:1 error Expected indentation of 6 spaces but found 4 indent
79:1 error Expected indentation of 8 spaces but found 6 indent
80:1 error Expected indentation of 8 spaces but found 6 indent
81:1 error Expected indentation of 10 spaces but found 8 indent
82:1 error Expected indentation of 8 spaces but found 6 indent
84:1 error Expected indentation of 8 spaces but found 6 indent
85:1 error Expected indentation of 6 spaces but found 4 indent
90:1 error Expected indentation of 6 spaces but found 4 indent
95:1 error Expected indentation of 6 spaces but found 4 indent
104:1 error Expected indentation of 6 spaces but found 4 indent
105:1 error Expected indentation of 8 spaces but found 6 indent
106:1 error Expected indentation of 6 spaces but found 4 indent
111:1 error Expected indentation of 6 spaces but found 4 indent
112:1 error Expected indentation of 8 spaces but found 6 indent
113:1 error Expected indentation of 8 spaces but found 6 indent
114:1 error Expected indentation of 10 spaces but found 8 indent
115:1 error Expected indentation of 8 spaces but found 6 indent
116:1 error Expected indentation of 8 spaces but found 6 indent
117:1 error Expected indentation of 6 spaces but found 4 indent
122:1 error Expected indentation of 6 spaces but found 4 indent
123:1 error Expected indentation of 8 spaces but found 6 indent
124:1 error Expected indentation of 6 spaces but found 4 indent
125:1 error Expected indentation of 6 spaces but found 4 indent
140:1 error Expected indentation of 6 spaces but found 4 indent
141:1 error Expected indentation of 6 spaces but found 4 indent
142:1 error Expected indentation of 6 spaces but found 4 indent
145:1 warning Block must not be padded by blank lines padded-blocks
✖ 35 problems (33 errors, 2 warnings)
```
Since
eslint
is used in the scripts at package.json#7, it also should be added as deps. Then users don't need to install it as a global deps becausenpm run
addnode_modules/.bin
toPATH
automatically.After that, the following logs are displayed when I ran
npm test
:click here
```console $ npm test > ethjs-ens@2.0.1 test /Users/watilde/Development/ethjs-ens > npm run lint && istanbul cover test && npm run coveralls > ethjs-ens@2.0.1 lint /Users/watilde/Development/ethjs-ens /Users/watilde/Development/ethjs-ens/index.js 18:11 warning Block must not be padded by blank lines padded-blocks 52:1 error Expected indentation of 6 spaces but found 4 indent 53:1 error Expected indentation of 8 spaces but found 6 indent 54:1 error Expected indentation of 10 spaces but found 8 indent 55:1 error Expected indentation of 8 spaces but found 6 indent 56:1 error Expected indentation of 8 spaces but found 6 indent 57:1 error Expected indentation of 6 spaces but found 4 indent 70:1 error Expected indentation of 6 spaces but found 4 indent 78:1 error Expected indentation of 6 spaces but found 4 indent 79:1 error Expected indentation of 8 spaces but found 6 indent 80:1 error Expected indentation of 8 spaces but found 6 indent 81:1 error Expected indentation of 10 spaces but found 8 indent 82:1 error Expected indentation of 8 spaces but found 6 indent 84:1 error Expected indentation of 8 spaces but found 6 indent 85:1 error Expected indentation of 6 spaces but found 4 indent 90:1 error Expected indentation of 6 spaces but found 4 indent 95:1 error Expected indentation of 6 spaces but found 4 indent 104:1 error Expected indentation of 6 spaces but found 4 indent 105:1 error Expected indentation of 8 spaces but found 6 indent 106:1 error Expected indentation of 6 spaces but found 4 indent 111:1 error Expected indentation of 6 spaces but found 4 indent 112:1 error Expected indentation of 8 spaces but found 6 indent 113:1 error Expected indentation of 8 spaces but found 6 indent 114:1 error Expected indentation of 10 spaces but found 8 indent 115:1 error Expected indentation of 8 spaces but found 6 indent 116:1 error Expected indentation of 8 spaces but found 6 indent 117:1 error Expected indentation of 6 spaces but found 4 indent 122:1 error Expected indentation of 6 spaces but found 4 indent 123:1 error Expected indentation of 8 spaces but found 6 indent 124:1 error Expected indentation of 6 spaces but found 4 indent 125:1 error Expected indentation of 6 spaces but found 4 indent 140:1 error Expected indentation of 6 spaces but found 4 indent 141:1 error Expected indentation of 6 spaces but found 4 indent 142:1 error Expected indentation of 6 spaces but found 4 indent 145:1 warning Block must not be padded by blank lines padded-blocks ✖ 35 problems (33 errors, 2 warnings) ```This patch is to fix them. Thanks!