search

ethlo / itu

An extremely fast parser and formatter of standardized date and date-times supporting RFC-3339 (ISO-8601 profile) and more.
Apache License 2.0
26 stars 8 forks source link

Version 1.10.1 and 1.10.2 have wrong java 9 module descriptor #33

Open aleruz-dt opened 3 months ago

aleruz-dt commented 3 months ago

While version 1.10.0 has 

module com.ethlo.time {
    exports com.ethlo.time;
}

as module descriptor, version 1.10.1 and 1.10.2 has

module com.ethlo.time {
    exports com.ethlo.time.token;
}

and this breaks the usage of the library in combination, for example, with json-schema-validator

Forcing the usage of version 1.10.0 makes it work again.

ethlo commented 3 months ago

I have no experience with how the OSGI modules should be packaged. I get a warning that there is a private reference to the package com.ethlo.time.token after this change.

aleruz-dt commented 3 months ago

I can try it, if you publish a version, maybe better a RC. To verify locally, you can check the module-info.java file present in the META-INF/versions/9 directory.

I have no experience with the maven plugins you are using, so I can't help there.