search

ethomson / jagged

java bindings to libgit2
MIT License
112 stars 28 forks source link

Repository: report isBare correctly on open #17

Closed carlosmn closed 10 years ago

carlosmn commented 10 years ago

When we init a repository, a constructor is called which receives the 'bare' param from the native method. This is not the case in the "normal" constructor, which opens a repository and thus must ask whether it is bare or not.

BTW, it looks like your domain name is misspelt in the travis file.

ethomson commented 10 years ago

Nice!

What kind of problems are you having with the tests? They seem to be doing well for me on Win, Mac and Linux (and Travis is happy, too). But I'm also not a maven expert, so I may be doing something stupid.

carlosmn commented 10 years ago

It turned out that I didn't have $TMPDIR set, so the GitTest static initializer failed. Being a static initialiser, it seems that it failiing makes the class loader upset, so then I got about five screenfuls of the jvm failing to load anything. Once I did scroll up all that error and noticed, I got the tests to pass.

Which makes me wonder why you're not asking the runtime via

System.getPropery("java.io.tmpdir")

if they fail.

ethomson commented 10 years ago

Which makes me wonder why you're not asking the runtime

Obviously we should be. Mind opening an issue or a PR?

carlosmn commented 10 years ago

Sure thing

carlosmn commented 10 years ago

Alright, this PR has a test now, and there's another one with the tmpdir fix.

ethomson commented 10 years ago

:sparkles: