ethpandaops / ethereum-package

A Kurtosis package that deploys a private, portable, and modular Ethereum devnet
MIT License
196 stars 100 forks source link

Label the geth-client that is spun up alongside the builder differently from the other geth clients on the Ethereum nodes #119

Closed leeederek closed 7 months ago

leeederek commented 11 months ago

Hey, when I run the eth2-package with full-mev, I expect there to be 2 Geth clients: 1 directly spun up with the MEV-builder, and another regular Geth client as part of an Ethereum full node.

In the output at the end (kurtosis enclave ls), it's not obvious to me as a user which one is which:

============================================== User Services ==============================================
UUID           Name                           Ports                                                  Status
e7f673086384   el-1-geth-lighthouse           engine-rpc: 8551/tcp -> 127.0.0.1:62861                RUNNING
                                              rpc: 8545/tcp -> 127.0.0.1:62863
                                              tcp-discovery: 30303/tcp -> 127.0.0.1:62862
                                              udp-discovery: 30303/udp -> 127.0.0.1:56858
                                              ws: 8546/tcp -> 127.0.0.1:62860
3048d9aafc12   el-2-geth-lighthouse           engine-rpc: 8551/tcp -> 127.0.0.1:62866                RUNNING
                                              rpc: 8545/tcp -> 127.0.0.1:62864
                                              tcp-discovery: 30303/tcp -> 127.0.0.1:62867
                                              udp-discovery: 30303/udp -> 127.0.0.1:62287
                                              ws: 8546/tcp -> 127.0.0.1:62865
barnabasbusa commented 8 months ago

I think this makes sense. We could append builder to the the clients that behave as a builder.

So in this case it would be el-2-geth-lighthouse-builder

bharath-123 commented 8 months ago

hey can i pick this up?! I have some free time want to spend some of it contributing to kurtosis! :D

barnabasbusa commented 8 months ago

go for it!!