fix: fix keymanager api for prysm

ethpandaops / ethereum-package

A Kurtosis package that deploys a private, portable, and modular Ethereum devnet

MIT License

260 stars 150 forks source link

fix: fix keymanager api for prysm #789

Closed TobiWo closed 1 month ago

TobiWo commented 1 month ago

Summary

This PR fixes the keymanager api feature for prysm which was not working. In detail it:

delete the unknown http flags and replaces them with the grpc-gateway flags since all REST APIs are exposed as gateway to the general grpc protocol
deletes the unused/unnecessary grpc port for the public port exposure

barnabasbusa commented 1 month ago

Lets wait for this PR to be merged once this is in stable prysm image.

barnabasbusa commented 1 month ago

Changing the default prysm img to point at latest stable instead of latest develop: https://github.com/ethpandaops/ethereum-package/pull/793

barnabasbusa commented 1 month ago

Actually, it looks like prysm stable branch is still using grpc-gateway, and latest develop uses http.

You might have had some older version of the prysm image locally.

barnabasbusa commented 1 month ago

is this pr still needed? Prysm made a new stable release that does http instead of grocery.

TobiWo commented 1 month ago

Please keep it open for now. I just need it as reference because I think there is still a bug in the prysm config (not related to grpc). I will test in the next days and will close it once I did all testing.

TobiWo commented 1 month ago

Closed as described here.