Following guidance of some new warnings in the latest Solium that recommend public modifiers be sequenced first in the modifier lists.
Have disabled warnings about:
block.timestamp: these values just stamp package creation / update dates . No consequential logic (within the contracts themselves) is tied to them.
some operator-whitespace warnings about lack of symmetry in a few locations where the right hand side of an assignment expression extends beyond GitHub's view window. Stepping those down onto subsequent lines for accessibility.
Also starting to run linter in CI and on npm test - we should start getting failures if style & security rules are violated.
Currently only have warnings about the absence of reason strings in our revert statements.
3
Following guidance of some new warnings in the latest Solium that recommend
public
modifiers be sequenced first in the modifier lists.Have disabled warnings about:
block.timestamp
: these values just stamp package creation / update dates . No consequential logic (within the contracts themselves) is tied to them.operator-whitespace
warnings about lack of symmetry in a few locations where the right hand side of an assignment expression extends beyond GitHub's view window. Stepping those down onto subsequent lines for accessibility.Also starting to run linter in CI and on
npm test
- we should start getting failures if style & security rules are violated.Currently only have warnings about the absence of reason strings in our revert statements.