modifies the ReleaseValidator contract to return an integer error code if validation fails (current behavior is to return boolean)
defines an integer code -> human readable message mapping in the validator contract.
modifies PackageIndex to revert with error message when release validation fails (current behavior is to silently succeed without executing the release.)
update tests to check for revert and appropriate error message.
This PR targets the allow-backfilling branch because they touch the same code / code has been removed in that PR.
NB: it might be cheaper to have the validator just return the strings? Not sure this implemented optimally at all. . .
13, #15.
ReleaseValidator
contract to return an integer error code if validation fails (current behavior is to return boolean)integer code -> human readable message
mapping in the validator contract.PackageIndex
to revert with error message when release validation fails (current behavior is to silently succeed without executing the release.)This PR targets the
allow-backfilling
branch because they touch the same code / code has been removed in that PR.NB: it might be cheaper to have the validator just return the strings? Not sure this implemented optimally at all. . .