search

ethpm / ethpm-cli

CLI tool for interacting with the ethPM ecosystem.
https://ethpm-cli.readthedocs.io/
MIT License
42 stars 12 forks source link

Registry explore cmd #92

Closed corydickson closed 4 years ago

corydickson commented 4 years ago

What was wrong?

Issue #88

How was it fixed?

Added a new subparser to registry that accepts a valid URI and prints the total releases with their corresponding version and manifest_uri as well as the package name.

Cute Animal Picture

put a cute animal picture link inside the parentheses

corydickson commented 4 years ago

I'll push a fix for the linter if the formatting looks good on the output and add the corresponding tests!

corydickson commented 4 years ago

Should have the tests ready this weekend, bit busy this week sorry for the delay

njgheorghita commented 4 years ago

@corydickson No worries! just ping me whenever this is ready for a review

corydickson commented 4 years ago

@njgheorghita Thank you for the patience, should be ready for review!

corydickson commented 4 years ago

May I make the changes suggested by the linter here?

njgheorghita commented 4 years ago

Also the mypy fixes are in master now if you want to rebase against master to fix the linting errors.

corydickson commented 4 years ago

lol sorry for the fp was having issues... should be rebased correctly

njgheorghita commented 4 years ago

Looks good, thanks @corydickson !!