search

ethpm / ethpm-spec

Ethereum Package Manager http://ethpm.github.io/ethpm-spec/
165 stars 30 forks source link

Update solidity and ipfs uris for transferable pkg #102

Closed njgheorghita closed 6 years ago

njgheorghita commented 6 years ago

Update solidity version used in transferable.sol Update ipfs links for transferable and owned pkg

njgheorghita commented 6 years ago

@gnidan good nitpick - I was thinking about that, and brief scan of the style guide couldn't find - i'm down to capitalize filenames. should we also capitalize the package name then?

njgheorghita commented 6 years ago

Actually - i'm good with capitalizing filename - and leaving package name uncapitalized. Not sure we need to push for a capitalized package name convention

gnidan commented 6 years ago

Agreed that package names should be lowercase (kebab-case is my fav!)

njgheorghita commented 6 years ago

mmmm. kebabs

davesque commented 6 years ago

@njgheorghita Did you notice my comment about the inconsistent indentation in examples/transferable/1.0.0.json?