search

ethpm / ethpm-spec

Ethereum Package Manager http://ethpm.github.io/ethpm-spec/
165 stars 30 forks source link

Ensure examples' package manifests are properly stripped of whitespace and sorted #105

Closed gnidan closed 6 years ago

gnidan commented 6 years ago

Since #77, this spec requires packages to be minified, but this repo still only provides the pretty-printed version in the examples/ directories.

I propose that we keep two copies of each example's JSON, one minified and sorted, the other kept with indentation and semantically-ordered object keys. This change can happen in one of two directions: a. 1.0.0.json for strict, 1.0.0-pretty.json for pretty b. 1.0.0.json for pretty, 1.0.0-strict.json for strict

Opening this issue to gauge others' thoughts. On the one hand, there's the risk of external links going bad, replaced with unreadable JSON content, but on the other hand, the strict form is canonical. I slightly prefer (a); other thoughts?

Thanks!

gnidan commented 6 years ago

Option:1.0.0.json is strict

gnidan commented 6 years ago

Option:1.0.0.json is pretty