search

ethpm / ethpm-spec

Ethereum Package Manager http://ethpm.github.io/ethpm-spec/
165 stars 30 forks source link

Update "URI" format in schema #136

Closed njgheorghita closed 5 years ago

njgheorghita commented 5 years ago

Format "URI" is undefined, and should be "uri".

unknown format "URI" is used in schema at path "#/definitions/PackageMeta/properties/links/additionalProperties"

Also updated some dependencies that had security vulnerabilities

pipermerriam commented 5 years ago

Any thoughts on a small test suite that validates the schema against known good/bad examples?

Also, current build is throwing a lot of red: https://travis-ci.org/ethpm/ethpm-spec/builds/531663245

njgheorghita commented 5 years ago

@pipermerriam We validate the schema against valid manifests here - and there is more testing done in py-ethpm here and here.

The bug fixed in this pr was only raised now because I just added a new tool in ethpm.js for json schema validation - so I guess the python json schema validation library just didn't pick up on it?

It's possible more invalid manifests should be tested against, but I'm not sure how far to take it or where to store them as there are many many possible invalid manifests, and clogging this library up with them might be distracting / confusing :shrug: