ethpm / ethpm-spec

Ethereum Package Manager http://ethpm.github.io/ethpm-spec/
165 stars 30 forks source link

Write tests for v3 jsonschema #147

Closed njgheorghita closed 4 years ago

njgheorghita commented 4 years ago

@pipermerriam It appears as though in V2 - a deployment can only refer to a contract type from a direct dependency.

{
  "buildDependencies": {
    "mydependency1": "ipfs://Qm..."
  },
  "deployments": {
    "blockchain://...": {
      "MyContract": {
        "contractType": "mydependency1:MyContract", // valid
        "contractType": "mydependency1:mydependency2:MyContract" // invalid
      }
    }
  }
}

Is there a reason why it's restricted to only reference contract types in a direct dependency - rather than multiple levels? We allow this kind of nested referencing for a [link value] - but is there a reason why we shouldn't allow this for a deployment's contract type?

pipermerriam commented 4 years ago

Is there a reason why it's restricted to only reference contract types in a direct dependency - rather than multiple levels?

No reason I can remember or think of. Seems like a bug/error in the spec.