search

ethpm / ethpm-spec

Ethereum Package Manager http://ethpm.github.io/ethpm-spec/
166 stars 30 forks source link

Disallow uppercase characters in package names #29

Closed pipermerriam closed 7 years ago

pipermerriam commented 7 years ago

Don't allow uppercase characters in package names.

tcoulter commented 7 years ago

👍

VoR0220 commented 7 years ago

No

pipermerriam commented 7 years ago

@VoR0220 I merged this due to the 3:1 vote. I am still curious to hear your why but without knowing the why I chose to go ahead and move forward with this. Still of course open for discussion.

VoR0220 commented 7 years ago

because if we want a mixed case, that could be useful. Also enables more differentiation.

tcoulter commented 7 years ago

I don't think we should allow people to make a distinction between monax-stdlib, Monax-stdlib, and monax-STDlib. Actually, thinking about it we probably don't want underscores unless we want to allow people to create monax-stdlib and monax_stdlib. We have enough naming issues already.

I vote no uppercase, no underscore.

VoR0220 commented 7 years ago

so I agree with not wanting to make the distinction, but I think mixedCase is useful.

tcoulter commented 7 years ago

Right, but how is it useful given my examples above of how it's not useful?

tcoulter commented 7 years ago

Reducing the namespace (character space) is probably better for everyone. e.g., http://bgr.com/2016/11/21/fake-google-vitaly-popov-scam-spam/

tcoulter commented 7 years ago

As an aside, is this something we can actually enforce?

VoR0220 commented 7 years ago

I suppose from the package manager level. But its kind of like an agreement we all make to do this. Not really enforceable for all newcomers who think our package managers suck :p