add escrow manifest with runtime bytecode to assets

ethpm / py-ethpm

This library is deprecated. ethPM python tooling is now located in web3.py

MIT License

24 stars 13 forks source link

add escrow manifest with runtime bytecode to assets #111

Closed njgheorghita closed 6 years ago

njgheorghita commented 6 years ago

What was wrong?

Need this manifest for testing in pytest-ethereum

How was it fixed?

Cute Animal Picture

![Cute animal picture]()

njgheorghita commented 6 years ago

merging since minor change

njgheorghita commented 6 years ago

@pipermerriam Yup sounds good, all the manifests should be valid a la the json-spec. Are you suggesting just adding a test that validates all the manifests in ethpm/assets/ - or something different like a separate circleci command that does the validation?

pipermerriam commented 6 years ago

Probably just a parametrized test that runs them through the validation, can be part of the existing CI test suite, no need for a new run that I see.

Make sure the test automatically detects new manifests (no hard coded list)
Make sure the test sanity checks in case the automated mechanism finds zero manifests which should be an error condition.