ethpm / py-ethpm

This library is deprecated. ethPM python tooling is now located in web3.py
MIT License
24 stars 13 forks source link

Add deployments feature to builder tool #120

Closed njgheorghita closed 5 years ago

njgheorghita commented 5 years ago

What was wrong?

Manifest builder tool needed some functions to facilitate adding a deployment to a manifest

How was it fixed?

added a deployment function, which simply allows you to pass in the desired deployment data

also added a deployment_type() function, which is slightly more complex, but allows for managing the same deployment across different chains, and some tx_receipt validation

Cute Animal Picture

image

njgheorghita commented 5 years ago

@pipermerriam ping for review. unsure how I feel about the deployment_type concept. i'm open to scrapping it temporarily, leaving only the simple deployment fn, and revisiting any w3-related validation post-devcon workshop