search

ethpm / py-ethpm

This library is deprecated. ethPM python tooling is now located in web3.py
MIT License
24 stars 13 forks source link

Ensure all source paths created by builder are relative #133

Closed njgheorghita closed 5 years ago

njgheorghita commented 5 years ago

What was wrong?

Builder was creating invalid paths for "sources", unless path was relative in the compiler output, it wouldn't be added to the manifest as a relative path, which is required by the spec

How was it fixed?

Added a util to check if path is relative - and return properly formatted path

Cute Animal Picture

image

pipermerriam commented 5 years ago

So a manifest has a set of source files, all of which exist in the virtual source tree.

so a file with the path ./owned.sol would exist in the root directory of that virtual source tree. The concept of installation would involve writing that source tree to disk somewhere and ensuring that none of the paths traverse outside of the root of the virtual source tree is how we can ensure that packages which would deposit files outside of that directory would be considered invalid.