search

ethpm / py-ethpm

This library is deprecated. ethPM python tooling is now located in web3.py
MIT License
24 stars 13 forks source link

Update to web3 v5 #137

Closed njgheorghita closed 5 years ago

njgheorghita commented 5 years ago

What was wrong?

update to web3 v5 and remove eth-abi dependency

Cute Animal Picture

🦔

mikeshultz commented 5 years ago

Would be pretty cool to get the web3[tester] splinter pulled out, or optional somehow. The web3[tester] splinter/extras don't look like they're required to run py-ethpm as a user. Not sure if this is the best way to go about it, but maybe something like this? 

from setuptools.command.develop import develop as _develop
from subprocess import check_call

[...]

class develop(_develop):
    """ Post-installation to make sure web3 tester extras are installed."""
    def run(self):
        _develop.run(self)
        check_call(['pip', 'install', 'web3[tester]>=5.0.0a2,<6.0.0'])

setup(
    [...]
    install_requires=[
        [...]
        'web3>=5.0.0a2,<6.0.0',
    ],
    [...]
    cmdclass={
        'develop': develop,
    },
)
njgheorghita commented 5 years ago

@mikeshultz Noted - created issue #140 to track, but moving ahead to merge this