Move utils to _utils namespace

ethpm / py-ethpm

This library is deprecated. ethPM python tooling is now located in web3.py

MIT License

24 stars 13 forks source link

Move utils to _utils namespace #163

Closed njgheorghita closed 5 years ago

njgheorghita commented 5 years ago

What was wrong?

WIP

/utils folder needs moving to /_utils to make the web3 merge cleaner and more consistent with web3 library.

THIS IS ONLY ABOUT HALF OF THE TOTAL REFACTOR I wanted to submit a pr to get feedback on whether or not this is moving in the right direction. As I understand it, anything in /_utils should NOT be part of the general API and only used internally.

Cute Animal Picture

njgheorghita commented 5 years ago

@pipermerriam What's the best strategy to get these breaking changes merged and compatible with pytest-ethereum/web3 without breaking everything? I was planning to minor version bump ethpm from v0.1.4a19 to v0.1.5a1. In which case all that needs to happen is pte and web3 need new versions released which raise their dependency to ethpm>=0.1.5a1? Does that sound about right?

njgheorghita commented 5 years ago

Another option, since this codebase is heading towards web3 anyway, is to just not cut another release of ethpm and migrate the code over to web3?