search

ethpm / py-ethpm

This library is deprecated. ethPM python tooling is now located in web3.py
MIT License
24 stars 13 forks source link

Write json fixture test groundwork #23

Closed njgheorghita closed 6 years ago

njgheorghita commented 6 years ago

Hey @pipermerriam, I took a shot at writing the fixture tests. I jacked a lot of the code / design from py-evm. Not sure if that was the best way to approach (adding unnecessary complexity)? Should I go ahead and create a json fixture test file for all the different kinds of packages? What other kinds of things belong in the fixture file? Right now it's really only testing that the Package object has certain attributes. Feedback on what's good / bad / needs changing would be really helpful, thanks!

What was wrong?

Project needs standardized json fixture tests to allow other py-ethpm implementations to develop against the same spec.

How was it fixed?

Started laying the groundwork for fixture tests.

Cute Animal Picture

giphy 39

closes #9

njgheorghita commented 6 years ago

Hey @pipermerriam ran into some nasty git issues with the old branch, but this is an exact duplicate, adjusted for ethan's pr. If there's anything else that needs to be added, holler.

pipermerriam commented 6 years ago

will take a look at it tomorrow.