ethpm / py-ethpm

This library is deprecated. ethPM python tooling is now located in web3.py
MIT License
24 stars 13 forks source link

Fetch URI from registry #46

Closed njgheorghita closed 6 years ago

njgheorghita commented 6 years ago

What was wrong?

Package object should be able to be instantiated via a Registry URI scheme.

How was it fixed?

Add a class method Package.from_registry(registry_uri, w3). Follows the Registry URI scheme as defined in #45

Cute Animal Picture

image

davesque commented 6 years ago

Very cool work, Nick. I left a couple of comments but mostly this looks like a great start on this functionality.

njgheorghita commented 6 years ago

Thanks @davesque! not sure why, but I can't see the comments you left? 🤷‍♂️

davesque commented 6 years ago

@njgheorghita I think it was because I hadn't "submitted" my review. Confusing. :/