Validate raw manifests are formatted correctly

ethpm / py-ethpm

This library is deprecated. ethPM python tooling is now located in web3.py

MIT License

24 stars 13 forks source link

Validate raw manifests are formatted correctly #75

Closed njgheorghita closed 5 years ago

njgheorghita commented 6 years ago

What was wrong?

The ethpm-spec requires certain constraints on how a manifest is formatted . . . #71

How was it fixed?

Added a validation util validate_raw_manifest_format to class methods for instantiating a package from a file

Cute Animal Picture

fixes #71

njgheorghita commented 5 years ago

@piper - ping!

njgheorghita commented 5 years ago

I'm 👎 on not requiring a content hash.

@pipermerriam It may have been lost to time/force pushes, but do you remember the context for this? I'm not really sure where requiring a content hash would play into this pr (maybe referring to the hash of a manifest's contents?) - in which case requiring that hash seems excessive to me 🤷‍♂️ Otherwise this is ready for 👓