search

ethpm / py-ethpm

This library is deprecated. ethPM python tooling is now located in web3.py
MIT License
24 stars 13 forks source link

Programmatically generate manifest #83

Closed njgheorghita closed 6 years ago

njgheorghita commented 6 years ago

What was wrong?

Feature: Programmatically generate manifest from solc output Still more or less a WIP but could use some feedback on whether or not it seems headed in the right direction.

How was it fixed?

Wrote class to manage manifest generation.

Cute Animal Picture

image

njgheorghita commented 6 years ago

@pipermerriam Ready for an initial review on this when you get the chance. Only super simple use cases are covered so far, any input on the best way to extend this to support handling options that come with bytecode objects, deployments, etc. would be great!

njgheorghita commented 6 years ago

@pipermerriam Thanks! Made the suggested changes, let me know if there are any other changes you'd like to see

njgheorghita commented 6 years ago

@pipermerriam Converted this to a more functional style of manifest generation as suggested. Followed the style used to link bytecode. When you get some time, any thoughts/suggestions for improvement would be super!