search

ethpm / py-ethpm

This library is deprecated. ethPM python tooling is now located in web3.py
MIT License
24 stars 13 forks source link

Add IPFS node to circle environment #86

Closed njgheorghita closed 6 years ago

njgheorghita commented 6 years ago

What was wrong?

Better testing of IPFS integration was needed.

How was it fixed?

Configured circle to start a ci node in the background we can run some integration tests against

Cute Animal Picture

image

njgheorghita commented 6 years ago

@pipermerriam Not sure what's the best way forward here. Circle now has an ipfs node available to run integration tests against. But, the tests will fail if a user runs them locally and doesn't have their own IPFS node running. Thoughts?

pipermerriam commented 6 years ago

I'd lump the tests into a separate test run and then add a pytest cli argument like this: https://github.com/ethereum/py-evm/blob/master/tests/trinity/conftest.py#L27-L29. You can then conditionally skip the tests based on the presence of that flag. Probably good to document this in the developer documentation.

njgheorghita commented 6 years ago

@pipermerriam Thanks, made the change. I was getting some weird behavior with Circle for a bit where it wasn't recursing through all the test files after adding the --integration flag to the pytest command, so I added tests/ to the command and it seems to be working fine now.