search

ethpm / py-ethpm

This library is deprecated. ethPM python tooling is now located in web3.py
MIT License
24 stars 13 forks source link

Remove eth-typing dependency #95

Closed njgheorghita closed 6 years ago

njgheorghita commented 6 years ago

What was wrong?

Whatever issue is going on with the eth-typing dependency, is no longer worth the effort to debug. This is a temporary solution, but since there are only a couple types being imported from eth-typing, I'm re-implementing the typing module here and adding the types.

How was it fixed?

Cute Animal Picture

image

njgheorghita commented 6 years ago

going ahead and merging since it's a minor fix and blocking, will revisit the eth-typing dependency before releasing stable alpha

pipermerriam commented 6 years ago

I'm totally not well versed on what the actual problem is but... this might be a cache thing:

https://github.com/ethpm/py-ethpm/blob/master/.circleci/config.yml#L41

You can add a v1- prefix to that and see what happens. (unfortunately that's how we bust caches in circle-ci)

njgheorghita commented 6 years ago

No clue what's going wrong, doesn't seem to be a problem with the circle cache since I can replicate this locally when installing into a fresh venv. Just going to stick with this temp fix and hope the bug somehow fixes itself magically when I come back to it