Closed jrhea closed 5 years ago
cc @ChihChengLiang
We use ethresearch/sharding-p2p:dev
because we have a docker hub ethresearch
repo. Would prefer fixing run-dev
to fixing build-dev
.
docker build -f docker/dev.Dockerfile -t ethresearch/sharding-p2p:dev .
run-dev:
- docker run -it --rm -v $(PWD):/go/src/github.com/ethresearch/sharding-p2p-poc ethereum/sharding-p2p:dev sh -c "go build -v -o main ."
+ docker run -it --rm -v $(PWD):/go/src/github.com/ethresearch/sharding-p2p-poc ethresearch/sharding-p2p:dev sh -c "go build -v -o main ."
test-dev: partial-gx-rw
docker run -it --rm -v $(PWD):/go/src/github.com/ethresearch/sharding-p2p-poc ethereum/sharding-p2p:dev sh -c "go test"
@mhchia my guess is that you didn't have an error before bc you already have a docker image with that name. Can you do a docker ps -a
to see all running and stopped containers. Just a guess
@ChihChengLiang and @mhchia based on @ChihChengLiang's feedback, I could change the image prefix to ethresearch for build-prod, build-dev, run-dev, and test-dev:
build-prod:
- docker build -f docker/prod.Dockerfile -t ethereum/sharding-p2p:latest .
+ docker build -f docker/prod.Dockerfile -t ethresearch/sharding-p2p:latest .
build-dev:
- docker build -f docker/dev.Dockerfile -t ethereum/sharding-p2p:dev .
+ docker build -f docker/dev.Dockerfile -t ethresearch/sharding-p2p:dev .
run-dev:
- docker run -it --rm -v $(PWD):/go/src/github.com/ethresearch/sharding-p2p-poc ethereum/sharding-p2p:dev sh -c "go build -v -o main ."
+ docker run -it --rm -v $(PWD):/go/src/github.com/ethresearch/sharding-p2p-poc ethresearch/sharding-p2p:dev sh -c "go build -v -o main ."
test-dev: partial-gx-rw
- docker run -it --rm -v $(PWD):/go/src/github.com/ethresearch/sharding-p2p-poc ethereum/sharding-p2p:dev sh -c "go test"
+ docker run -it --rm -v $(PWD):/go/src/github.com/ethresearch/sharding-p2p-poc ethresearch/sharding-p2p:dev sh -c "go test"
gx-go uw
Is that what you what?
Thanks @jrhea , that's the desired change ❤️
Thanks @jrhea . After merging this, one should run the command to rebuild the docker images. The rebuild would just change the tag for the image, should be fast.
What is wrong?
I get an 'unable to find image' error when busting a make run-dev:
How can it be fixed?
Fix the docker build command in the Makefile:
Cute Animal Picture