search

ethresearch / sharding-p2p-poc

Proof of Concept of Ethereum Serenity Peer-to-Peer Layer on libp2p PubSub System
40 stars 19 forks source link

Nondeterministic PeerID #119

Closed araskachoi closed 5 years ago

araskachoi commented 5 years ago

What is wrong?

When creating a peerID using the seed, the peerID seems to be non-deterministic. At times, I get one PID but at others, I get another one.

seed=0 : QmS5QmciTXXnCUCyxud5eWFenUMAmvAWSDa1c7dvdXRMZ7 / QmSmiLDiPpVVaduZiWnADC6LBSEEgG2RR5ZjnLCCKoDARa / Qmd8vXqRiFVkcXcB1nigjCDuUyHcFkja6fQcU9w2zMzwwi seed=1 : QmexAnfpHrhMmAC5UNQVS8iBuUUgDrMbMY17Cck2gKrqeX / Qmeq45rCLjFt573aFKgLrcAmAMSmYy9WXTuetDsELM2r8m seed=2 : Qmd3wzD2HWA95ZAs214VxnckwkwM4GHJyC6whKUCNQhNvW / QmYpiXBsV6DbJwCnNEeVETKpgdS2yRAGuw82Dd4XdPs5yY / QmXtW5fXrrvmHWPhq3FLHdm4zKnC5FZdhTRynSQT57Yrmd

I had spoken to @mhchia about heard about someone looking into this. I recently got the error connected to wrong peer because the bootnode's PID had changed from Qm...XRMZ7 to Qm...Mzwwi.

NIC619 commented 5 years ago

Hmm…this should be fixed by #113 . Can you confirm that you are using the latest branch or one that has #113 merged?

araskachoi commented 5 years ago

ah, didn't see the pull request for this fix. I had brought it up to @mhchia and was told someone was on it but never got an update on its fix. Thanks a lot for the help!