Cleanup Dockerfiles - Githubissues

ethresearch / sharding-p2p-poc

Proof of Concept of Ethereum Serenity Peer-to-Peer Layer on libp2p PubSub System

40 stars 19 forks source link

Cleanup Dockerfiles #124

Closed ChihChengLiang closed 5 years ago

ChihChengLiang commented 5 years ago

What is wrong?

docker-compose.ymls are rarely used recently, due to most of the nodes simulation are easier and thus preferably done by handcrafted scripts.
prod.Dockerfile is rarely used too.

How can it be fixed?

Remove all docker-compose.yml
Replace prod.Dockerfile and dev.Dockerfile to a new Dockerfile. Don't touch test/Dockerfile, but try to make the new Dockerfile compatible with it.
- Add EXPOSE 8369 8370 13000 6831 6831/udp
Update Makefile.

ChihChengLiang commented 5 years ago

Addressed in #125