search

ethresearch / sharding-p2p-poc

Proof of Concept of Ethereum Serenity Peer-to-Peer Layer on libp2p PubSub System
40 stars 19 forks source link

Save broadcast collations #14

Closed mhchia closed 6 years ago

mhchia commented 6 years ago

Description

Collations are broadcast with the command broadcastcollation. It generates collations of a specified size(through adjusting the size of Blobs field). Currently, a node doesn't save the collations it receives in memory or database, whereas it just puts them in a cache in pubsub for a period(for now is 30 seconds) and relays the message. We should save it in order to be requested by other nodes.

Requirements

Save collations in memory or storage. If the size and number are not large, saving them in memory is enough. However, if we do performance test, those big collations will use of the memory.

mhchia commented 6 years ago

Close it because this should be done in python layer