ethresearch / sharding-p2p-poc

Proof of Concept of Ethereum Serenity Peer-to-Peer Layer on libp2p PubSub System
40 stars 19 forks source link

Add tracing(Opentracing + Appdash) #33

Closed NIC619 closed 6 years ago

NIC619 commented 6 years ago

How was it fixed?

Add some basic tracing setup(Opentracing + Appdash) to keep track of the RPC calls between different nodes in the network:

WIP: Look into libp2p codebase to see how they set up and utilize tracing WIP: survey for different/better visualization tools

Cute Animal Picture

put a cute animal picture link inside the parentheses

mhchia commented 6 years ago

Reference to https://github.com/ethresearch/sharding-p2p-poc/issues/27

mhchia commented 6 years ago

TODOs

mhchia commented 6 years ago

I merged this branch with master, and modified partial-gx-uw.py to print the unwritten imports. Let's see what errors occur in the CI now

mhchia commented 6 years ago

Ah...I just removed fstring. Hope we can get rid of the error. Thanks a lot @ChihChengLiang

NIC619 commented 6 years ago

Seems like we forgot to fetch the dependency packages recursively while the command go test -v ./… will run the tests recursively(hence it would run into the cannot find package of XXX error.

As for the previous undefined: proto.GoGoProtoPackageIsVersion1 error, the reason seems to be that the wrong version of package gogo/protobuf/proto is fetched by gx and it's currently fixed by gx unwrite the specified packages.

mhchia commented 6 years ago

So we need to pass ./... to go get and go test, to build all packages under the directory, and pass . to go get in docker, since we only need the exact main package in the directory to make it build? Btw., CI passed!