search

ethresearch / sharding-p2p-poc

Proof of Concept of Ethereum Serenity Peer-to-Peer Layer on libp2p PubSub System
40 stars 19 forks source link

Update run.sh #39

Closed zscole closed 6 years ago

zscole commented 6 years ago

Added header

What was wrong?

no header declaration

How was it fixed?

added one

Cute Animal Picture

put a cute animal picture link inside the parentheses

zscole commented 6 years ago

Ah ok, that makes sense. Lol. Sorry. I’ll update first thing in the morning.

Sent from my iPhone

On Aug 8, 2018, at 10:16 PM, Kevin Mai-Husan Chia notifications@github.com wrote:

@mhchia commented on this pull request.

In docker/cmd/run.sh:

@@ -1,5 +1,7 @@

!/bin/bash

+chmod +x run.sh Ahhhh...sorry that I made you misunderstand. I mean chmod this file docker/cmd/run.sh to make it executable. This way the shebang is recognized when ./run.sh is run, and /bin/bash will be used to interpret run.sh

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or mute the thread.

ChihChengLiang commented 6 years ago

oops, sorry I accidentally did the same fix in #38 .