Change type `blobs` in message Collation from string to []byte - Githubissues

ethresearch / sharding-p2p-poc

Proof of Concept of Ethereum Serenity Peer-to-Peer Layer on libp2p PubSub System

40 stars 19 forks source link

Change type `blobs` in message Collation from string to []byte #41

Closed mhchia closed 6 years ago

mhchia commented 6 years ago

What was wrong?

"proto: invalid utf-8 string" occurs in addpeer and broadcastcollation. Reference: https://github.com/ethresearch/sharding-p2p-poc/pull/33#issuecomment-411469138

How was it fixed?

Change type blobs in message Collation from string to []byte

Additionally

Isolate a test to listeningshards_test.go
Refactor Hash to keccak and GetCollationHash

TODO

Refactor the tests
Debug issue in AddPeer

Cute Animal Picture

![put a cute animal picture link inside the parentheses]()

mhchia commented 6 years ago

cc @NIC619