fix the -v mount issue in Makefile - Githubissues

ethresearch / sharding-p2p-poc

Proof of Concept of Ethereum Serenity Peer-to-Peer Layer on libp2p PubSub System

40 stars 19 forks source link

fix the -v mount issue in Makefile #42

Closed qizhong19920114 closed 6 years ago

qizhong19920114 commented 6 years ago

What was wrong?

Compile from dev Getting error saying that "exec: \"/main\": permission denied: unknown

How was it fixed?

The issue is in the Makefile: run-dev: docker run -it --rm -v $(PWD):/go/sharding-p2p/ ethereum/sharding-p2p:dev sh -c "go build -v -o main ."

This command is mounted to the wrong directory than the WORDIR defined in Dockerfile. So the main binary won't be copied to the host directory.

Fix: run-dev: docker run -it --rm -v $(PWD):/go/src/github.com/ethresearch/sharding-p2p-poc ethereum/sharding-p2p:dev sh -c "go build -v -o main ."

mhchia commented 6 years ago

@NIC619 Are you fine with merging this PR?