Separate rpc server and client and some small refactor

ethresearch / sharding-p2p-poc

Proof of Concept of Ethereum Serenity Peer-to-Peer Layer on libp2p PubSub System

40 stars 19 forks source link

Closed NIC619 closed 6 years ago

NIC619 commented 6 years ago

[x] Separate rpc.go into rpcserver.go and rpcclient.go.
[x] Remove the built-in PublishListeningShards in ListenShard/UnlistenShard and do PublishListeningShards after every ListenShard/UnlistenShard instead.
[x] Make fromSlice/fromBytes/toBytes part of ListeningShards
[x] Move functions except keccak in utils.go back to the file where they were used the most often.

put a cute animal picture link inside the parentheses

mhchia commented 6 years ago

Generally looks good to me. However, CI failed?

mhchia commented 6 years ago

Seems the CI failure isn't related to the changes in this PR. It might be DHT's issue again. I reopened https://github.com/ethresearch/sharding-p2p-poc/issues/2 to track this.