Switch tracer to jaeger and add tracing to ShardManager functions

ethresearch / sharding-p2p-poc

Proof of Concept of Ethereum Serenity Peer-to-Peer Layer on libp2p PubSub System

40 stars 19 forks source link

Closed NIC619 closed 6 years ago

NIC619 commented 6 years ago

Switch tracer: Jaeger has better UI, all-in-one container for easy setup and we can also get rid of the Appdash dependency problem.

[x] Switch from Appdash to Jaeger
[x] Small refactor on organizing info(by Tag/Baggage) in each branch in the overall graph
[x] Add tracing to functions one level deeper - the ShardManager functions called by each RPC call

put a cute animal picture link inside the parentheses

mhchia commented 6 years ago

Could you add the reason why we switch from Appdash to Jaeger?

mhchia commented 6 years ago

Would you mind also providing some snapshots and docs about how to use it? Thanks a lot

mhchia commented 6 years ago

LGTM. Note: it seems feasible if we can place ctx in the Node in the future, that case there is no need to pass them from outside.