Closed mhchia closed 5 years ago
Reverted the version update of some deps in https://github.com/ethresearch/sharding-p2p-poc/pull/54/commits/576dd2278c644567b99ff51da46670e09e33bd82, which should be solved in other PR Tracked in https://github.com/ethresearch/sharding-p2p-poc/issues/55
Ready for review
Note: TODO: add documents for "how to communicate with shardingp2p nodes and receive notification from them"
What was wrong?
How was it fixed?
EventNotifier
(currently done through gRPC). It send data to Python side from Golang, and thus Python side send the response back to GolangNotifyCollation(collation) returns bool
: send new received collations from Golang side to Python, and get the validation result of the collation:isValid
GetCollation(shardID, period, collationHash) returns collation
: send "collation request" from Golang to Python side, and ask for collations from Python side.Validator
for content validationValidator
function in pubsub for collations' topics. This Validator simply sends collations from Golang to Python throughEventNotifier.NotifyCollation
, the collation is validated in Python side, and send the validation result from Python side back to GolangSendCollation
for Python side to send blocksShardPrefTable
with added locks to avoid race condition: https://github.com/ethresearch/sharding-p2p-poc/issues/57TODOs
getCollation
toeventNotifier
eventNotifier
ShardPrefTable
Cute Animal Picture