search

ethresearch / sharding-p2p-poc

Proof of Concept of Ethereum Serenity Peer-to-Peer Layer on libp2p PubSub System
40 stars 19 forks source link

Renaming `eventNotifier` #58

Closed mhchia closed 5 years ago

mhchia commented 5 years ago

What is wrong?

EventNotifier introduced in https://github.com/ethresearch/sharding-p2p-poc/pull/54 is used to communicate with the Python side. It is named as this because first it only supports NotifyCollation, which is used for Golang side to notify the Python side. However, I added another function GetCollation, which is used for Golang side to ask for collations from the Python side. The functionalities of EventNotifier becomes not only "notifying".

How can it be fixed?

Come up with a better name. Thanks for the advice from @ChihChengLiang . We might need to first define the name of "Python side", and then we can define what EventNotifier should be named after.

ChihChengLiang commented 5 years ago

proposing Host for the Python side and p2pGadget for the Golang side.